Skip to content
This repository was archived by the owner on Jan 10, 2023. It is now read-only.

Output video scores on a json file#2

Open
joelsole wants to merge 1 commit intogoogle:mainfrom
joelsole:main
Open

Output video scores on a json file#2
joelsole wants to merge 1 commit intogoogle:mainfrom
joelsole:main

Conversation

@joelsole
Copy link
Copy Markdown

@joelsole joelsole commented May 13, 2021

No description provided.

@google-cla
Copy link
Copy Markdown

google-cla bot commented May 13, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

nbirkbeck
nbirkbeck reviewed May 31, 2021
View reviewed changes
src/video_band_detect.m
end
s.all_scores = json_BBAD_V;
fileID = fopen('bband_results.json', 'w');
fprintf(fileID, jsonencode(s));
Copy link
Copy Markdown
Contributor

@nbirkbeck nbirkbeck May 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also fclose(fileID) to avoid file handle leaks

@google-cla
Copy link
Copy Markdown

google-cla bot commented Jun 4, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@nbirkbeck nbirkbeck nbirkbeck left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joelsole @nbirkbeck